colornames
Posted: Sun Oct 02, 2016 3:37 am
Pull request 4290 partially fixed bug 7344 (it's marked as fixed in LC8.1, but actually not so much).
There are two files in ide/Toolset/resources/supporting_files/colors that still need updating, colorsToNames.txt and namesToColors.txt.
I went to fix them up, but there's a header at the top of the files that says
/* This mapping comes from engine/src/rgb.cpp and should not be changed */
So before I waste even more time on this,
A. It's obvious that there's no automated build procedure to generate those files from rgb.cpp.
B. Should I ignore the warning and edit the files, or should the fix be to autogenerate the files from the cpp source?
B sounds like a better strategy in the long run, but A is an easy win.
And this isn't a pedantic issue, because as pointed out in another thread, the following line still breaks because of this:
Edit:
Hmmm...
Looking at the code in uidc.cpp, it seems that the color tables in rgb.cpp are used after all, and the supporting files are just orphans.
I'm still working on wrapping my brain around the while(low < high) section in lookupcolor().
There are two files in ide/Toolset/resources/supporting_files/colors that still need updating, colorsToNames.txt and namesToColors.txt.
I went to fix them up, but there's a header at the top of the files that says
/* This mapping comes from engine/src/rgb.cpp and should not be changed */
So before I waste even more time on this,
A. It's obvious that there's no automated build procedure to generate those files from rgb.cpp.
B. Should I ignore the warning and edit the files, or should the fix be to autogenerate the files from the cpp source?
B sounds like a better strategy in the long run, but A is an easy win.
And this isn't a pedantic issue, because as pointed out in another thread, the following line still breaks because of this:
Code: Select all
set the backgroundcolor of button 1 to "Gray3"
Hmmm...
Looking at the code in uidc.cpp, it seems that the color tables in rgb.cpp are used after all, and the supporting files are just orphans.
I'm still working on wrapping my brain around the while(low < high) section in lookupcolor().